Re: [PATCH] pack-objects: fix --no-keep-true-parents

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 21, 2023, 17:03 UTC
Message-ID: <xmqqtttxurgi.fsf@gitster.g>
In-Reply-To: <fe7e43a0-5f08-73a7-fd04-b9127592b45c@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 9 quoted lines

> Since 99fb6e04cb (pack-objects: convert to use parse_options(),
> 2012-02-01) git pack-objects has accepted --no-keep-true-parents, but
> this option does the same as --keep-true-parents.  That's because it's
> defined using OPT_SET_INT with a value of 0, which sets 0 when negated
> as well.
>
> Turn --no-keep-true-parents into the opposite of --keep-true-parents by
> using OPT_BOOL and storing the option's status directly in a variable
> named "grants_keep_true_parents" instead of in negative form in

"grant" -> "graft" (locally fixed, no need to resend).

> "grafts_replace_parents".
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.