Re: [PATCH] show-branch: fix --no-sparse
- From
René Scharfe <l.s.r@web.de>
- Date
- Jul 21, 2023, 16:30 UTC
- Message-ID
- <b4912737-4ee1-11a5-847e-39c8eb2967d0@web.de>
- In-Reply-To
- <xmqqwmytxr59.fsf@gitster.g>
Am 21.07.23 um 16:42 schrieb Junio C Hamano:
Show 12 quoted lines
> > Hmph, am I expected to compare these patches with what I sent a few > days ago and pick whichever are the better ones? Can I delegate > that task to somebody else ;-)? > > jc/am-parseopt-fix <xmqqr0p5gjv3.fsf@gitster.g> > jc/branch-parseopt-fix <xmqqjzuxgjmi.fsf@gitster.g> > jc/describe-parseopt-fix <xmqqy1jcgbiv.fsf@gitster.g> > jc/parse-options-reset <xmqq1qh4c998.fsf@gitster.g> > jc/parse-options-short-help <xmqq5y6gg8fn.fsf@gitster.g> > jc/parse-options-show-branch <xmqqh6pzc15n.fsf@gitster.g> > jc/transport-parseopt-fix <xmqqedl4gag8.fsf@gitster.g>
Aww, didn't see them.
Most differences are cosmetic, but in git describe you use two OPT_SET_INT_F for the two OPT_SET_INT_Fs for --exact-match and --no-exact-match. The callback I chose is a little uglier on the inside, but prettier on the outside -- occupies a single line in short help. Reminds me of the --[no-]keep-cr simplification in git am.
And you don't seem to have touched pack-objects; please check those two patches of mine.
René