Re: [PATCH v1 1/6] Allow --porcelain[=<n>] in status and commit commands

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 20, 2016, 20:46 UTC
Message-ID: <xmqqshv4ca1z.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1468966258-11191-2-git-send-email-jeffhost@microsoft.com>

Jeff Hostetler <jeffhost@microsoft.com> writes:

Show 13 quoted lines

> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
> index b0a294d..0791573 100644
> --- a/Documentation/git-commit.txt
> +++ b/Documentation/git-commit.txt
> @@ -104,7 +104,7 @@ OPTIONS
>  --branch::
>  	Show the branch and tracking info even in short-format.
>  
> ---porcelain::
> +--porcelain[=<version>]::
>  	When doing a dry-run, give the output in a porcelain-ready
>  	format. See linkgit:git-status[1] for details. Implies
>  	`--dry-run`.

I suspect that it would be easier to implement to allow "commit --porcelain", but I am not sure if it truly makes sense. Not a new problem, though.

Show 17 quoted lines

> diff --git a/Documentation/git-status.txt b/Documentation/git-status.txt
> index e1e8f57..de97729 100644
> --- a/Documentation/git-status.txt
> +++ b/Documentation/git-status.txt
> @@ -32,11 +32,14 @@ OPTIONS
>  --branch::
>  	Show the branch and tracking info even in short-format.
>  
> ---porcelain::
> +--porcelain[=<version>]::
>  	Give the output in an easy-to-parse format for scripts.
>  	This is similar to the short output, but will remain stable
>  	across Git versions and regardless of user configuration. See
>  	below for details.
> ++
> +The version parameter is used to specify the format version.
> +This is optional and defaults to the original version '1' format.

I agree with Peff that "v1" would be easier to read, and also his comment on parsing using strcmp() to require exact matches and resetting to NONE, not UNSPECIFIED.