Re: [PATCH v1 0/6] Porcelain Status V2

From: Jeff King <peff@peff.net>
Date: Jul 20, 2016, 16:15 UTC
Message-ID: <20160720161543.GD24902@sigill.intra.peff.net>
In-Reply-To: <1468966258-11191-1-git-send-email-jeffhost@microsoft.com>

On Tue, Jul 19, 2016 at 06:10:52PM -0400, Jeff Hostetler wrote:

Show 11 quoted lines

> This patch series adds porcelain V2 format to status.
> This provides detailed information about file changes
> and about the current branch.
> 
> The new output is accessed via:
>     git status --porcelain=2 [--branch]
> 
> An earlier draft of this work was submitted under the
> "Add very verbose porcelain output to status" title.
> This new version addresses the concerns about using
> (abusing) "-vv" and simplifies the some of the formatting.

I reviewed the first two, which look good except for a few minor comments. I don't have time at the moment to dig carefully into the v2 format itself from the later patches (but from a cursory view they look OK). I'm flying all day today, so probably won't get to a more thorough review for a day or two (but if there are other reviewers, please don't feel you have to wait for my input).

One final bit of food for thought.

Just yesterday somebody asked me about renewing the old idea of using a more standardized format for machine-readable output, like --json. That's obviously something that would exist alongside the existing formats for compatibility, and it doesn't fundamentally change anything about adding a new format as your patches do (it just becomes yet another format).

However I wanted to mention it in case you are intrigued by the idea, and would be interested in skipping porcelain-v2 entirely in favor of moving to something like json.

A totally reasonable response is "haha no. Please stop moving the goalposts". I just wanted to throw it out there as an option (and in case you are interested, to let you think about it before any more work goes into this direction).

-Peff