Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 17, 2018, 23:50 UTC
- Message-ID
- <xmqqsh8yxnwu.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180317160832.GB15772@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> Unfortunately I think that's hard to do in pure make. But we're already > relying on $(shell) here, so we could just move the logic there. > > Something like the patch below, perhaps. It should do the right thing on > clang and gcc, and I added in an extra clang-only warning I've found > useful. Otherwise the list of flags comes from your patch.
I see this discussion is going in the right direction, and like the approach taken by this "how about this" patch.
Thanks.