Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

From: Jeff King <peff@peff.net>
Date: Mar 17, 2018, 15:16 UTC
Message-ID: <20180317151648.GA15772@sigill.intra.peff.net>
In-Reply-To: <D8137CD9-9E11-4FBC-B89B-907C007FC6E9@gmail.com>

On Sat, Mar 17, 2018 at 03:29:31PM +0100, Lars Schneider wrote:

Show 13 quoted lines

> >> Why isn't this just turning on DEVELOPER=1 if we know we have a capable
> >> compiler?
> > 
> > DEVELOPER=1 is always set even before this patch. It's set and
> > exported in lib-travisci.sh.
> 
> I interpreted Peff's comment like this:
> 
> If DEVELOPER=1 is set and we detect a gcc-6 in the makefile, 
> then we could set your additional flags in the makefile.
> 
> This way every developer with a new compiler would run these
> flags locally (if DEVELOPER=1 is set).

Actually, I was mostly just confused, and didn't realize that these were going above and beyond what's in DEVELOPER.

But that said, now that I understand, I agree completely with your suggestion. :)

-Peff