Re: [PATCH v2] Makefile: detect compiler and enable more warnings in DEVELOPER=1

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 26, 2018, 22:02 UTC
Message-ID: <xmqqlgeebiml.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180324125348.6614-1-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> The set of extra warnings we enable when DEVELOPER has to be
> conservative because we can't assume any compiler version the
> developer may use. Detect the compiler version so we know when it's
> safe to enable -Wextra and maybe more.

This is a good idea in general, but we are not quite ready without some fixups.

Here is a quick summary (not exhaustive) from my trial merge to 'pu' (which will be reverted before today's integration is pushed out).

 - json-writer.c triggers -Werror=old-style-decl

 - t/helper/test-json-writer.c triggers Werror=missing-prototypes
   quite a few times.

 - connect.c -Werror=implicit-fallthough around die_initial_contact().