Re: [PATCH v6 2/6] reset: introduce show-new-head-line option

From

Junio C Hamano <gitster@pobox.com>

Date

Apr 2, 2018, 20:34 UTC

Message-ID

<xmqqsh8dxs86.fsf@gitster-ct.c.googlers.com>

In-Reply-To

<20180331151804.30380-3-t.gummerer@gmail.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

> +test_expect_success 'reset --no-show-new-head-line suppresses "HEAD is now at" output' '
> +	git reset --hard --no-show-new-head-line HEAD >actual &&
> +	! grep "HEAD is now at" <actual
> +'

As builtin/reset.c::print_new_head_line() does this:

	printf(_("HEAD is now at %s"), hex);

this needs to use "test_i18ngrep !" instead, no?