Re: [PATCH v2 3/3] worktree: teach "add" to check out existing branches
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 5, 2018, 20:20 UTC
- Message-ID
- <xmqqh8qv9ojb.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180205021833.GB17847@duynguyen.dek-tpc.internal>
Duy Nguyen <pclouds@gmail.com> writes:
Show 9 quoted lines
> On Sun, Feb 04, 2018 at 10:13:05PM +0000, Thomas Gummerer wrote:
>> - if (opts->new_branch)
>> + if (opts->checkout_existing_branch)
>> + fprintf(stderr, _(", checking out existing branch '%s'"),
>> + refname);
>> + else if (opts->new_branch)
>> fprintf(stderr, _(", creating new branch '%s'"), opts->new_branch);
>
> I wonder if "creating branch" and "checkout out branch" are enough.Yeah, I think new/existing are redundant. If these were shown at the same time, then the extra adjectives would help differenciating them visually, but they are never shown at the same time, so...