[PATCH v7 4/4] worktree: teach "add" to check out existing branches
- From
Thomas Gummerer <t.gummerer@gmail.com>
- Date
- Apr 15, 2018, 20:29 UTC
- Message-ID
- <20180415202917.4360-5-t.gummerer@gmail.com>
- In-Reply-To
- <20180415202917.4360-1-t.gummerer@gmail.com>
Currently 'git worktree add <path>' creates a new branch named after the basename of the path by default. If a branch with that name already exists, the command refuses to do anything, unless the '--force' option is given.
However we can do a little better than that, and check the branch out if it is not checked out anywhere else. This will help users who just want to check an existing branch out into a new worktree, and save a few keystrokes.
As the current behaviour is to simply 'die()' when a branch with the name of the basename of the path already exists, there are no backwards compatibility worries here.
We will still 'die()' if the branch is checked out in another worktree, unless the --force flag is passed.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> --- Documentation/git-worktree.txt | 9 +++++++-- builtin/worktree.c | 30 ++++++++++++++++++++++++------ t/t2025-worktree-add.sh | 26 +++++++++++++++++++------- 3 files changed, 50 insertions(+), 15 deletions(-)
diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt index 41585f535d..5d54f36a71 100644 --- a/Documentation/git-worktree.txt +++ b/Documentation/git-worktree.txt @@ -61,8 +61,13 @@ $ git worktree add --track -b <branch> <path> <remote>/<branch> ------------ + If `<commit-ish>` is omitted and neither `-b` nor `-B` nor `--detach` used, -then, as a convenience, a new branch based at HEAD is created automatically, -as if `-b $(basename <path>)` was specified. +then, as a convenience, the new worktree is associated with a branch +(call it `<branch>`) named after `$(basename <path>)`. If `<branch>` +doesn't exist, a new branch based on HEAD is automatically created as +if `-b <branch>` was given. If `<branch>` does exist, it will be +checked out in the new worktree, if it's not checked out anywhere +else, otherwise the command will refuse to create the worktree (unless +`--force` is used). list:: diff --git a/builtin/worktree.c b/builtin/worktree.c index 893139629a..f5a5283b39 100644 --- a/builtin/worktree.c +++ b/builtin/worktree.c @@ -355,9 +355,12 @@ static int add_worktree(const char *path, const char *refname, static void print_preparing_worktree_line(const char *branch, const char *new_branch, - const char *new_branch_force) + const char *new_branch_force, + int checkout_existing_branch) { - if (new_branch_force) { + if (checkout_existing_branch) { + printf_ln(_("Preparing worktree (checking out '%s')"), branch); + } else if (new_branch_force) { struct commit *commit = lookup_commit_reference_by_name(new_branch_force); if (!commit) printf_ln(_("Preparing worktree (new branch '%s')"), new_branch_force); @@ -378,11 +381,23 @@ static void print_preparing_worktree_line(const char *branch, } } -static const char *dwim_branch(const char *path, const char **new_branch) +static const char *dwim_branch(const char *path, const char **new_branch, + int *checkout_existing_branch) { int n; const char *s = worktree_basename(path, &n); - *new_branch = xstrndup(s, n); + const char *branchname = xstrndup(s, n); + struct strbuf ref = STRBUF_INIT; + + if (!strbuf_check_branch_ref(&ref, branchname) && + ref_exists(ref.buf)) { + *checkout_existing_branch = 1; + strbuf_release(&ref); + UNLEAK(branchname); + return branchname; + } + + *new_branch = branchname; if (guess_remote) { struct object_id oid; const char *remote = @@ -397,6 +412,7 @@ static int add(int ac, const char **av, const char *prefix) struct add_opts opts; const char *new_branch_force = NULL; char *path; + int checkout_existing_branch = 0; const char *branch; const char *new_branch = NULL; const char *opt_track = NULL; @@ -444,7 +460,8 @@ static int add(int ac, const char **av, const char *prefix) } if (ac < 2 && !new_branch && !opts.detach) { - const char *s = dwim_branch(path, &new_branch); + const char *s = dwim_branch(path, &new_branch, + &checkout_existing_branch); if (s) branch = s; } @@ -464,7 +481,8 @@ static int add(int ac, const char **av, const char *prefix) } } - print_preparing_worktree_line(branch, new_branch, new_branch_force); + print_preparing_worktree_line(branch, new_branch, new_branch_force, + checkout_existing_branch); if (new_branch) { struct child_process cp = CHILD_PROCESS_INIT; diff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh index 2b95944973..ad38507d00 100755 --- a/t/t2025-worktree-add.sh +++ b/t/t2025-worktree-add.sh @@ -198,13 +198,25 @@ test_expect_success '"add" with <branch> omitted' ' test_cmp_rev HEAD bat ' -test_expect_success '"add" auto-vivify does not clobber existing branch' ' - test_commit c1 && - test_commit c2 && - git branch precious HEAD~1 && - test_must_fail git worktree add precious && - test_cmp_rev HEAD~1 precious && - test_path_is_missing precious +test_expect_success '"add" checks out existing branch of dwimd name' ' + git branch dwim HEAD~1 && + git worktree add dwim && + test_cmp_rev HEAD~1 dwim && + ( + cd dwim && + test_cmp_rev HEAD dwim + ) +' + +test_expect_success '"add <path>" dwim fails with checked out branch' ' + git checkout -b test-branch && + test_must_fail git worktree add test-branch && + test_path_is_missing test-branch +' + +test_expect_success '"add --force" with existing dwimd name doesnt die' ' + git checkout test-branch && + git worktree add --force test-branch ' test_expect_success '"add" no auto-vivify with --detach and <branch> omitted' '
-- 2.17.0.252.gfe0a9eaf31