Re: [PATCH v9 0/4] worktree: teach "add" to check out existing branches

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 30, 2018, 00:07 UTC
Message-ID: <xmqqh8ntzhe4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180428160950.GA17619@hank.intra.tgummerer.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

Show 19 quoted lines

> On 04/27, Eric Sunshine wrote:
>> On Tue, Apr 24, 2018 at 5:56 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
>> > Thanks Eric for the review and the suggestions on the previous round.
>> >
>> > Changes since the previous round:
>> >
>> > - UNLEAK new_branch after it was xstrndup'd
>> > - update the commit message of 2/4 according to Eric's suggestions
>> > - make force_new_branch a boolean flag in
>> >   print_preparing_worktree_line, instead of using it as the branch
>> >   name.  Instead use new_branch as the new branch name everywhere in
>> >   that function.
>> > - get rid of the ckeckout_existing_branch flag
>> 
>> Thanks. I did another full review of all the patches and played around
>> with the new functionality again for good measure. Everything looked
>> good, and I think the patches are now ready to graduate.
>
> Thanks for all your review work on this series!

Thanks, both.