Re: [RFC PATCH 3/9] sequencer: update `total_nr' when adding an item to a todo list

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2019, 19:52 UTC
Message-ID: <xmqqsgr3xgr6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190717143918.7406-4-alban.gruin@gmail.com>

Alban Gruin <alban.gruin@gmail.com> writes:

> `total_nr' is the total amount of items, done and toto, that are in a

"amount" -> "number" perhaps. Also s/toto/todo/ perhaps but I am not sure what you wanted to say here, so...

> todo list.  But unlike `nr', it was not updated when an item was
> appended to the list.

Good finding.

Show 15 quoted lines

>
> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
> ---
>  sequencer.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sequencer.c b/sequencer.c
> index cf262701e8..e61ae75451 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -2070,6 +2070,7 @@ void todo_list_release(struct todo_list *todo_list)
>  static struct todo_item *append_new_todo(struct todo_list *todo_list)
>  {
>  	ALLOC_GROW(todo_list->items, todo_list->nr + 1, todo_list->alloc);
> +	++todo_list->total_nr;

When we do not use the value in an expression, we prefer post increment, not pre increment.

>  	return todo_list->items + todo_list->nr++;
>  }