Re: [PATCH v3 0/2] rebase -i: extend rebase.missingCommitsCheck
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 4, 2019, 21:51 UTC
- Message-ID
- <xmqqmuc73gk7.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20191202234759.26201-1-alban.gruin@gmail.com>
Alban Gruin <alban.gruin@gmail.com> writes:
Show 12 quoted lines
> To prevent mistakes when editing a branch, rebase features a knob, > rebase.missingCommitsCheck, to warn the user if a commit was dropped. > Unfortunately, this check is only effective for the initial edit, which > means that if you edit the todo list at a later point of the rebase and > drop a commit, no warnings or errors would be issued. > ... > rebase-interactive.c | 57 ++++++++++++++++++++---- > rebase-interactive.h | 2 + > sequencer.c | 53 ++++++---------------- > sequencer.h | 1 - > t/t3404-rebase-interactive.sh | 83 +++++++++++++++++++++++++++++++++++ > 5 files changed, 147 insertions(+), 49 deletions(-)
This passes the self-test when tested by itself, but when merged near the tip of 'pu', it breaks t3404.116, it seems.