Re: [PATCH v2 1/2] Fit to Plan 9's ANSI/POSIX compatibility layer
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 9, 2020, 20:34 UTC
- Message-ID
- <xmqqsgbqu1to.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CAPig+cQ_KCAGpmfBAymBefB2JSVpw0-bk5HOnm41=SpADEyDnA@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 26 quoted lines
> On Wed, Sep 9, 2020 at 3:48 PM Kyohei Kadota via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> And its sed(1)'s label is limited to maximum seven characters.
>> Therefore I replaced some labels to drop a character.
>>
>> * close -> cl
>> * continue -> cont (cnt is used for count)
>> * line -> ln
>> * hered -> hdoc
>> * shell -> sh
>> * string -> str
>
> These are reasonable. "cl" feels a little odd, but I can't think of
> anything better.
>
>> diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh
>> @@ -24,7 +24,7 @@ category_list () {
>> get_synopsis () {
>> sed -n '
>> - /^NAME/,/'"$1"'/H
>> + /^NAME/,/'"$1"'/h
>
> This change is not mentioned in the commit message. "H" and "h" are
> very different commands, so it's difficult, at a glance, to tell if
> this change is even valid. Some explanation in the commit message
> would help (if it is indeed valid).I am glad somebody else caught the same thing as I did. copying and appending will give very different results.
Thanks.