Re: [PATCH 1/4] Use $(SHELL_PATH) instead of sh in Makefile.
- From
Kyohei Kadota <lufia@lufia.org>
- Date
- Aug 6, 2020, 14:39 UTC
- Message-ID
- <CAFMepckNybt8drZ=5c3x3MvUyruB75nn0cNY34FRpu=supsFiA@mail.gmail.com>
- In-Reply-To
- <CAPig+cRe2OUeHXE3XELtkS7b2GrZVxLm0pzduojDB97uLnBZKQ@mail.gmail.com>
Show 17 quoted lines
> On Wed, Aug 5, 2020 at 10:14 PM brian m. carlson > <sandals@crustytoothpaste.net> wrote: > > On 2020-08-06 at 01:05:01, lufia via GitGitGadget wrote: > > > In the not POSIX environment, like Plan 9, sh might not be looked up > > > in the directories named by the $PATH. > > > > I think Git's editor handling assumes that sh is somewhere in the PATH, > > so it might be fine for us to just ask the user to adjust PATH > > appropriately before running make. I don't have a strong preference; if > > this works on a standard Unix machine, which it looks like it should > > (although I haven't tested), I'm fine with it. > > This does, however, have a bit of a chicken-and-egg feel to it. The > results of the "uname_FOO" assignments in config.mak.uname are > consulted later in the file to _assign_ a value to SHELL_PATH on a > number of platforms. So, making the "uname_FOO" assignments themselves > depend upon SHELL_PATH is rather circular and confusing.
The problem is, Plan 9 APE's sh is placed on /bin/ape/sh by default. By running /bin/ape/psh APE commands existed under /bin/ape such as sh, uname, etc, will be mounted on /bin. In running of ape/psh, APE commands will prioritize than native commands. So I've wanted to run /bin/ape/psh before executing some shell commands by gmake.
---- kadota