Re: [PATCH 3/4] Fit to Plan 9's ANSI/POSIX compatibility layer
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 6, 2020, 23:57 UTC
- Message-ID
- <CAPig+cSAnwbRYAVB5B8XdBKso=kQt=8CBB-U_Z-Wc+Sp2s54Hw@mail.gmail.com>
- In-Reply-To
- <20200806235139.GB8085@camp.crustytoothpaste.net>
On Thu, Aug 6, 2020 at 7:52 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:
Show 7 quoted lines
> On 2020-08-06 at 13:49:43, Kyohei Kadota wrote: > > I see. If I'd like to put those wrappers to the repository, is there > > the best place for them? > > If you can stuff them in a shell function, then I'd just put those in a > file like t/test-lib-wrappers.sh and conditionally source them from > t/test-lib.sh.
There are already platform-specific shell functions in test-lib.sh[1] and some larger compatibility functions in test-lib-functions.sh[2], so those might be better locations for Plan9 compatibility wrappers than creating a new file (or not?).
[1]: see the section commented:
"Fix some commands on Windows, and other OS-specific things"
[2]: see, for instance, the mingw_test_cmp() function