Re: [PATCH v2 1/2] Fit to Plan 9's ANSI/POSIX compatibility layer

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 9, 2020, 19:56 UTC
Message-ID: <CAPig+cQ_KCAGpmfBAymBefB2JSVpw0-bk5HOnm41=SpADEyDnA@mail.gmail.com>
In-Reply-To: <c850888c25d4d1e1c6b0ca40ab4638462c1649fa.1599680861.git.gitgitgadget@gmail.com>

On Wed, Sep 9, 2020 at 3:48 PM Kyohei Kadota via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 9 quoted lines

> And its sed(1)'s label is limited to maximum seven characters.
> Therefore I replaced some labels to drop a character.
>
> * close -> cl
> * continue -> cont (cnt is used for count)
> * line -> ln
> * hered -> hdoc
> * shell -> sh
> * string -> str

These are reasonable. "cl" feels a little odd, but I can't think of anything better.

Show 6 quoted lines

> diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh
> @@ -24,7 +24,7 @@ category_list () {
>  get_synopsis () {
>         sed -n '
> -               /^NAME/,/'"$1"'/H
> +               /^NAME/,/'"$1"'/h

This change is not mentioned in the commit message. "H" and "h" are very different commands, so it's difficult, at a glance, to tell if this change is even valid. Some explanation in the commit message would help (if it is indeed valid).