git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pretty-formats.txt: fix whitespace

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 25, 2023, 17:24 UTC
Message-ID
<xmqqsf72upxk.fsf@gitster.g>
In-Reply-To
<CACZqfqCVsv-ZaSRWt_ejMn5f_U_1E2h7wsCgUg_50A+KHzOgkA@mail.gmail.com>
Josh Soref <jsoref@gmail.com> writes:
Show 11 quoted lines
>> > * comma after `etc.` when not ending a sentence
>>
>> There is one instance that says "A, B, C, D, etc., are all accepted."
>> without the comma after 'etc.' and the patch corrects it.  OK.
>
> It seems like this is the only change that's of interest.
>
> Do I just make a distinct gitgitgadget PR with that change, or do I
> ask it to mark that single change as a V2 to this? (given the branch
> name assumed whitespace and the only change would be a comma, it'd be
> kinda wrong...)
;-)

Up to you. If I were doing this patch, I would wait and see if others chime in (to support other changes in v1 that I was on the negative side) and then make v2 with the changes you still believe in when that happens.

Thanks.
Previous: Josh SorefNext: Linus Arver
Message 4 of 10 in “pretty-formats.txt: fix whitespace”
  1. pretty-formats.txt: fix whitespaceJosh Soref via GitGitGadget, Sep 22, 2023
  2. Junio C HamanoSep 22, 2023
  3. Josh SorefSep 24, 2023
  4. Junio C HamanoSep 25, 2023
  5. Linus ArverSep 26, 2023
  6. Josh SorefSep 26, 2023
  7. Linus ArverSep 26, 2023
  8. Kristoffer HaugsbakkSep 25, 2023
  9. Josh SorefSep 26, 2023
  10. Junio C HamanoSep 26, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.