Re: [PATCH] pretty-formats.txt: fix whitespace
- From
Josh Soref <jsoref@gmail.com>
- Date
- Sep 26, 2023, 19:51 UTC
- Message-ID
- <CACZqfqC3HWOuveQdbpVEEO5KOwmnugvUmm6M0WpVu2MtUopm-w@mail.gmail.com>
- In-Reply-To
- <owlypm24sr6n.fsf@fine.c.googlers.com>
Linus Arver wrote:
Show 17 quoted lines
> FWIW we already have some guidelines about what is acceptable for doc
> patches in SubmittingPatches:
>
> We currently have a liberal mixture of US and UK English norms for
> spelling and grammar, which is somewhat unfortunate. A huge patch that
> touches the files all over the place only to correct the inconsistency
> is not welcome, though. Potential clashes with other changes that can
> result from such a patch are not worth it. We prefer to gradually
> reconcile the inconsistencies in favor of US English, with small and
> easily digestible patches, as a side effect of doing some other real
> work in the vicinity (e.g. rewriting a paragraph for clarity, while
> turning en_UK spelling to en_US). Obvious typographical fixes are much
> more welcomed ("teh -> "the"), preferably submitted as independent
> patches separate from other documentation changes.
>
> and both the 2-space vs 1-space and comma changes seem to fall into the
> "not welcome" category.Ok, then, I think at this point I'll abandon this PR.
I could probably find the time to justify rewriting one paragraph in this single file to try to abide by the requirements, but it doesn't seem worth it. I'm sorry I wasted everyone's time.