git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pretty-formats.txt: fix whitespace

From
LALinus Arver <linusa@google.com>
Date
Sep 26, 2023, 21:20 UTC
Message-ID
<owlymsx8skbp.fsf@fine.c.googlers.com>
In-Reply-To
<CACZqfqC3HWOuveQdbpVEEO5KOwmnugvUmm6M0WpVu2MtUopm-w@mail.gmail.com>
Josh Soref <jsoref@gmail.com> writes:
Show 24 quoted lines
> Linus Arver wrote:
>> FWIW we already have some guidelines about what is acceptable for doc
>> patches in SubmittingPatches:
>>
>>     We currently have a liberal mixture of US and UK English norms for
>>     spelling and grammar, which is somewhat unfortunate.  A huge patch that
>>     touches the files all over the place only to correct the inconsistency
>>     is not welcome, though.  Potential clashes with other changes that can
>>     result from such a patch are not worth it.  We prefer to gradually
>>     reconcile the inconsistencies in favor of US English, with small and
>>     easily digestible patches, as a side effect of doing some other real
>>     work in the vicinity (e.g. rewriting a paragraph for clarity, while
>>     turning en_UK spelling to en_US).  Obvious typographical fixes are much
>>     more welcomed ("teh -> "the"), preferably submitted as independent
>>     patches separate from other documentation changes.
>>
>> and both the 2-space vs 1-space and comma changes seem to fall into the
>> "not welcome" category.
>
> Ok, then, I think at this point I'll abandon this PR.
>
> I could probably find the time to justify rewriting one paragraph in
> this single file to try to abide by the requirements, but it doesn't
> seem worth it.

The change to make a paragraph read better (fixes to awkward wording, for example) are very much appreciated and would be good as a follow-up patch in its own right.

> I'm sorry I wasted everyone's time.

Please don't let this experience deter you from considering future contributions to our documentation. Thanks.

Previous: Josh SorefNext: Kristoffer Haugsbakk
Message 7 of 10 in “pretty-formats.txt: fix whitespace”
  1. pretty-formats.txt: fix whitespaceJosh Soref via GitGitGadget, Sep 22, 2023
  2. Junio C HamanoSep 22, 2023
  3. Josh SorefSep 24, 2023
  4. Junio C HamanoSep 25, 2023
  5. Linus ArverSep 26, 2023
  6. Josh SorefSep 26, 2023
  7. Linus ArverSep 26, 2023
  8. Kristoffer HaugsbakkSep 25, 2023
  9. Josh SorefSep 26, 2023
  10. Junio C HamanoSep 26, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.