git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pretty-formats.txt: fix whitespace

From
Josh Soref <jsoref@gmail.com>
Date
Sep 26, 2023, 02:51 UTC
Message-ID
<CACZqfqCfvWASMPMxRpRuAUQPcprcB4RHxxke_qTZ3bFGLf3T8Q@mail.gmail.com>
In-Reply-To
<f3081838-ca50-4a7d-b2fc-6f0f1f1364a8@app.fastmail.com>
> From: Josh Soref <jsoref@gmail.com>
> * two spaces after periods for sentences
Kristoffer Haugsbakk wrote:
> Where's the two-spacing convention documented? I didn't find it in
> `CodingGuidelines` or `SubmittingPatches`.

There appeared to be too many instances of two spaces after a period in the file to be accidental. In some ways, it was an invitation for people to indicate if they have a preference.

I personally do not have a preference between two spaces after and one space after, but I do have a preference against a mix of two spaces after and one space after.

As it (IMO) takes effort (admittedly trivial, and quite likely habitual) to insert a second space, I assume that this was a desired thing and the one space was the aberration, hence the patch went in favor of two spaces.

I'd just as soon submit a patch the other way (and if people have an opinion one way or the other, I'm happy to include a change to CodingGuidelines/SubmittingPatches based on people's opinions).

Previous: Kristoffer HaugsbakkNext: Junio C Hamano
Message 9 of 10 in “pretty-formats.txt: fix whitespace”
  1. pretty-formats.txt: fix whitespaceJosh Soref via GitGitGadget, Sep 22, 2023
  2. Junio C HamanoSep 22, 2023
  3. Josh SorefSep 24, 2023
  4. Junio C HamanoSep 25, 2023
  5. Linus ArverSep 26, 2023
  6. Josh SorefSep 26, 2023
  7. Linus ArverSep 26, 2023
  8. Kristoffer HaugsbakkSep 25, 2023
  9. Josh SorefSep 26, 2023
  10. Junio C HamanoSep 26, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.