Re: [PATCH v2 8/8] builtin/fsck: add `git refs verify` child process
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 30, 2025, 19:03 UTC
- Message-ID
- <xmqqsep0ceec.fsf@gitster.g>
- In-Reply-To
- <Z5r7NnzvirWEljwV@ArchLinux>
shejialuo <shejialuo@gmail.com> writes:
Show 9 quoted lines
> +static void fsck_refs(struct repository *r)
> +{
> + struct child_process refs_verify = CHILD_PROCESS_INIT;
> + struct progress *progress = NULL;
> + uint64_t progress_num = 1;
> +
> + if (show_progress)
> + progress = start_progress(r, _("Checking ref database"),
> + progress_num);I do not see why we need an extra variable progress_num here. Just passing a literal constant 1 should be sufficient. The called function has function prototype to help the compiler promite it to the appropritate type.
Thanks.