Re: [PATCH v3 7/8] packed-backend: check whether the "packed-refs" is sorted

> On Wed, Feb 12, 2025 at 10:56:56AM +0100, Patrick Steinhardt wrote:
> > On Thu, Feb 06, 2025 at 01:59:55PM +0800, shejialuo wrote:
> > > diff --git a/refs/packed-backend.c b/refs/packed-backend.c
> > > index 658f6bc7da..0fbdc5c3fa 100644
> > > --- a/refs/packed-backend.c
> > > +++ b/refs/packed-backend.c
> > > -	return 0;
> > > +	string_list_split_in_place(&traits, p, " ", -1);
> > > +	*sorted = unsorted_string_list_has_string(&traits, "sorted");
> > 
> > I think we call them capabilities, not traits.
> > 
> 
> Yes, capabilities will be more semantic. But the original code in
> "packed-backend.c" uses "traits". Let us follow the original style to
> make sure consistency.