Re: [PATCH v2 3/8] packed-backend: check whether the "packed-refs" is regular

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 3, 2025, 08:40 UTC
Message-ID: <Z6CA7ZIBuY_YBV1Y@pks.im>
In-Reply-To: <Z5r6-52eBgT4TUYG@ArchLinux>

On Thu, Jan 30, 2025 at 12:07:23PM +0800, shejialuo wrote:

> Although "git-fsck(1)" and "packed-backend.c" will check some
> consistency and correctness of "packed-refs" file, they never check the
> filetype of the "packed-refs". The user should always use "git
> packed-refs" command to create the raw regular "packed-refs" file, so we

It's `git pack-refs`, not `git packed-refs`.

Otherwise I'm not going to comment on the rest of the commit, as Junio has already sufficiently discussed it with you, and I very much agree with his assessment that we don't need to discuss whether or not to use `open_nofollow()` in this depth.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.