Re: [PATCH v2 8/8] builtin/fsck: add `git refs verify` child process
- From
shejialuo <shejialuo@gmail.com>
- Date
- Jan 31, 2025, 14:37 UTC
- Message-ID
- <Z5zgIp7k0Z9kscmt@ArchLinux>
- In-Reply-To
- <xmqqsep0ceec.fsf@gitster.g>
On Thu, Jan 30, 2025 at 11:03:55AM -0800, Junio C Hamano wrote:
Show 16 quoted lines
> shejialuo <shejialuo@gmail.com> writes:
>
> > +static void fsck_refs(struct repository *r)
> > +{
> > + struct child_process refs_verify = CHILD_PROCESS_INIT;
> > + struct progress *progress = NULL;
> > + uint64_t progress_num = 1;
> > +
> > + if (show_progress)
> > + progress = start_progress(r, _("Checking ref database"),
> > + progress_num);
>
> I do not see why we need an extra variable progress_num here. Just
> passing a literal constant 1 should be sufficient. The called
> function has function prototype to help the compiler promite it to
> the appropritate type.You are correct, let me improve this in the next version.
Thanks, Jialuo