Re: [PATCH 3/7] test patch hunk editing with "commit -p -m"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 17, 2014, 18:49 UTC
- Message-ID
- <xmqqr460ek3k.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1394919750-28432-3-git-send-email-benoit.pierre@gmail.com>
Benoit Pierre <benoit.pierre@gmail.com> writes:
Show 12 quoted lines
> Add (failing) tests: with commit changing the environment to let hooks > know that no editor will be used (by setting GIT_EDITOR to ":"), the > "edit hunk" functionality does not work (no editor is launched and the > whole hunk is committed). > > Signed-off-by: Benoit Pierre <benoit.pierre@gmail.com> > --- > t/t7513-commit-patch.sh | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100755 t/t7513-commit-patch.sh > > diff --git a/t/t7513-commit-patch.sh b/t/t7513-commit-patch.sh
Again, as I said, I'll rename this to t7514-commit.patch.sh while I queue this.
Thanks.
Show 37 quoted lines
> new file mode 100755 > index 0000000..9311b0c > --- /dev/null > +++ b/t/t7513-commit-patch.sh > @@ -0,0 +1,32 @@ > +#!/bin/sh > + > +test_description='hunk edit with "commit -p -m"' > +. ./test-lib.sh > + > +if ! test_have_prereq PERL > +then > + skip_all="skipping '$test_description' tests, perl not available" > + test_done > +fi > + > +test_expect_success 'setup (initial)' ' > + echo line1 >file && > + git add file && > + git commit -m commit1 > +' > + > +test_expect_failure 'edit hunk "commit -p -m message"' ' > + test_when_finished "rm -f editor_was_started" && > + echo more >>file && > + echo e | env GIT_EDITOR="touch editor_was_started" git commit -p -m commit2 file && > + test -r editor_was_started > +' > + > +test_expect_failure 'edit hunk "commit --dry-run -p -m message"' ' > + test_when_finished "rm -f editor_was_started" && > + echo more >>file && > + echo e | env GIT_EDITOR="touch editor_was_started" git commit -p -m commit3 file && > + test -r editor_was_started > +' > + > +test_done