Re: [PATCH 4/7] commit: fix patch hunk editing with "commit -p -m"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 19, 2014, 17:19 UTC
- Message-ID
- <xmqqbnx25cnp.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <53294808.8030106@web.de>
Torsten Bögershausen <tboegi@web.de> writes:
Show 11 quoted lines
>> +int run_hook_with_custom_index(const char *index_file, const char *name, ...)
>> +{
>> + const char *hook_env[3] = { NULL };
>> + char index[PATH_MAX];
> Sorry being late with the review.
>
> Recently some effort has been put to replace the
> "PATH_MAX/snprintf() combo" with code using strbuf.
>
> So I think for new developed code it could make sense to avoid
> PATH_MAX from the start.Yes but because this is a compatibility wrapper for an existing function that does the string[PATH_MAX] thing already, it would be clearer to have such a conversion as a separate step.