Re: [PATCH 7/7] run-command: mark run_hook_with_custom_index as deprecated

From: Benoit Pierre <benoit.pierre@gmail.com>
Date: Mar 11, 2014, 17:37 UTC
Message-ID: <CA+SSzV3z5zQaEgJX_LC6j7FmfNYi-eC_7_UA=KWQBBooOpkgBQ@mail.gmail.com>
In-Reply-To: <20140311010039.GD4271@vauxhall.crustytoothpaste.net>

On Tue, Mar 11, 2014 at 2:00 AM, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 20 quoted lines

> On Mon, Mar 10, 2014 at 07:49:37PM +0100, Benoit Pierre wrote:
>> ---
>>  run-command.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/run-command.h b/run-command.h
>> index 88460f9..3653bfa 100644
>> --- a/run-command.h
>> +++ b/run-command.h
>> @@ -51,6 +51,7 @@ extern int run_hook_le(const char *const *env, const char *name, ...);
>>  extern int run_hook_ve(const char *const *env, const char *name, va_list args);
>>
>>  LAST_ARG_MUST_BE_NULL
>> +__attribute__((deprecated))
>
> It doesn't appear that we use the deprecated attribute anywhere else in
> the code.  Wouldn't it just be better to change the places that use this
> and then remove the function altogether?  I imagine your current patch
> might introduce a number of warnings that some people would rather
> avoid.

This last patch is optional. There are no callers to run_hook_with_custom_index, so no warnings for now. See discussion on first draft as to why I added it:

http://article.gmane.org/gmane.comp.version-control.git/243561

-- 
A: Because it destroys the flow of conversation.
Q: Why is top posting dumb?