Re: [PATCH v4 00/12] ref-filter: use parsing functions
Karthik Nayak <karthik.188@gmail.com> writes:
Show 34 quoted lines
> This series cleans up populate_value() in ref-filter, by moving out
> the parsing part of atoms to separate parsing functions. This ensures
> that parsing is only done once and also improves the modularity of the
> code.
>
> v1: http://thread.gmane.org/gmane.comp.version-control.git/281180
> v2: http://thread.gmane.org/gmane.comp.version-control.git/282563
> v3: http://thread.gmane.org/gmane.comp.version-control.git/283350
>
> Changes:
> * The parsing functions now take the arguments of the atom as
> function parameteres, instead of parsing it inside the fucntion.
> * Rebased on top of pu:jk/list-tag-2.7-regression
> * In strbuf use a copylen variable rather than using multiplication
> to perform a logical operation.
> * Code movement for easier review and general improvement.
> * Use COLOR_MAXLEN as the maximum size for the color variable.
> * Small code changes.
> * Documentation changes.
> * Fixed incorrect style of test (t6302).
>
> Karthik Nayak (12):
> strbuf: introduce strbuf_split_str_omit_term()
> ref-filter: use strbuf_split_str_omit_term()
> ref-filter: bump 'used_atom' and related code to the top
> ref-filter: introduce struct used_atom
> ref-filter: introduce parsing functions for each valid atom
> ref-filter: introduce color_atom_parser()
> ref-filter: introduce parse_align_position()
> ref-filter: introduce align_atom_parser()
> ref-filter: align: introduce long-form syntax
> ref-filter: introduce remote_ref_atom_parser()
> ref-filter: introduce contents_atom_parser()
> ref-filter: introduce objectname_atom_parser()
Hmm, 10/12 didn't make it to the list?