Re: [PATCH v4 09/12] ref-filter: align: introduce long-form syntax
On Fri, Feb 5, 2016 at 5:30 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 34 quoted lines
> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> Introduce optional prefixes "width=" and "position=" for the align atom
>> so that the atom can be used as "%(align:width=<width>,position=<position>)".
>>
>> Add Documentation and tests for the same.
>>
>> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
>> ---
>> diff --git a/t/t6302-for-each-ref-filter.sh b/t/t6302-for-each-ref-filter.sh
>> @@ -133,6 +133,48 @@ test_expect_success 'right alignment' '
>> +cat >expect <<-\EOF
>> +| refname is refs/heads/master |refs/heads/master
>> +| refname is refs/heads/side |refs/heads/side
>> +| refname is refs/odd/spot |refs/odd/spot
>> +| refname is refs/tags/double-tag |refs/tags/double-tag
>> +| refname is refs/tags/four |refs/tags/four
>> +| refname is refs/tags/one |refs/tags/one
>> +| refname is refs/tags/signed-tag |refs/tags/signed-tag
>> +| refname is refs/tags/three |refs/tags/three
>> +| refname is refs/tags/two |refs/tags/two
>> +EOF
>> +
>> +test_align_permutations() {
>> + while read -r option
>> + do
>> + test_expect_success "align:$option" '
>> + git for-each-ref --format="|%(align:$option)refname is %(refname)%(end)|%(refname)" >actual &&
>> + test_cmp expect actual
>> + '
>
> I think I mentioned this in the last round: The two lines following
> test_expect_success() are actually the test body, thus should be
> indented one more level. (Not necessarily worth a re-roll, though...)
>I must have missed it, will change it.
Show 28 quoted lines
>> + done
>> +}
>> +
>> +test_align_permutations <<-\EOF
>> + middle,42
>> + 42,middle
>> + position=middle,42
>> + 42,position=middle
>> + middle,width=42
>> + width=42,middle
>> + position=middle,width=42
>> + width=42,position=middle
>> +EOF
>> +
>> +# Last one wins (silently) when multiple arguments of the same type are given
>> +
>> +test_align_permutations <<-\EOF
>> + 32,width=42,middle
>> + width=30,42,middle
>> + width=42,position=right,middle
>> + 42,right,position=middle
>> +EOF
>> +
>> # Individual atoms inside %(align:...) and %(end) must not be quoted.
>>
>> test_expect_success 'alignment with format quote' "
>> --
>> 2.7.0
--
Regards,
Karthik Nayak
Karthik Nayak <karthik.188@gmail.com>