Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 3, 2016, 08:01 UTC
- Message-ID
- <xmqqr3gunrxq.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160203035648.GA20732@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Just when I dare to think "somebody cannot possibly be relying on this > arcane behavior", I am proven wrong. :)
My thoughts, exactly. This is the kind of thing that makes this project uncomfortably "interesting"; we cannot make improvements without risking breaking existing users.
Show 5 quoted lines
> Could we perhaps do this more cleanly with a new config
> option? Like a "user.guessIdent" which defaults to true, but people can
> set to false. And without that, we do not do any automagic at all; we
> get the values from the GIT_COMMITTER_* environment or the
> user.{name,email} config variables, or we die().That sounds like an excellent and clean way to do this.