git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] Add user.explicit boolean for when ident shouldn't be guessed

From
Dan Aloni <alonid@gmail.com>
Date
Feb 4, 2016, 09:07 UTC
Message-ID
<20160204090711.GA24020@gmail.com>
In-Reply-To
<20160204055035.GA13537@sigill.intra.peff.net>
On Thu, Feb 04, 2016 at 12:50:35AM -0500, Jeff King wrote:
Show 23 quoted lines
> On Thu, Feb 04, 2016 at 07:36:46AM +0200, Dan Aloni wrote:
>[..]
> > The code should be cleaned up anyway. I only delved into that code for
> > the first time two days ago, so it would take me more time to come up
> > with a new one (though reading your overview here of the cases is going
> > to be helpful, thanks).
> 
> Feel free to look into this direction, but having pushed a little
> further towards the "simple" approach (with the 2 patches I just sent),
> I think that does what you want without too much complication. I'd be
> fine, too, if you wanted to pick those up[1] and put the finishing
> touches on the second one.
> 
> -Peff
> 
> [1] To clarify, since you are new to the git.git workflow: I'd expect
>     you to use `git am` to pick up my two patches. Leave me as the
>     author of the first cleanup patch. Squash your additions onto the
>     second one using `cherry-pick`, `commit --amend`, or whatever, and
>     make sure to `commit --reset-author` so that you're the author. Post
>     both as part of the v4 re-roll.
> 
>     But that's just "here is what I meant", not "what you have to do". :)

Thanks. Being familiar with Linux kernel patch submission process, good to be focused about git.git's idiosyncrasies too.

The cleanup was easy thanks to your patches. Going to post v4.
-- 
Dan Aloni
Previous: Jeff King
Message 16 of 16 in “Trick to force setup of a specific configured E-Mail per repo”
  1. Trick to force setup of a specific configured E-Mail per repoDan Aloni, Feb 2, 2016
  2. Jeff KingFeb 3, 2016
  3. Duy NguyenFeb 3, 2016
  4. Jeff KingFeb 3, 2016
  5. Duy NguyenFeb 3, 2016
  6. Jeff KingFeb 3, 2016
  7. Junio C HamanoFeb 3, 2016
  8. Dan AloniFeb 3, 2016
  9. Eric SunshineFeb 3, 2016
  10. Add user.explicit boolean for when ident shouldn't be guessedDan Aloni, Feb 3, 2016
  11. Jeff KingFeb 4, 2016
  12. Jeff KingFeb 4, 2016
  13. Jeff KingFeb 4, 2016
  14. Dan AloniFeb 4, 2016
  15. Jeff KingFeb 4, 2016
  16. Dan AloniFeb 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.