Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Feb 3, 2016, 05:19 UTC
- Message-ID
- <CACsJy8BHem_8OcnT9KYhKZVhNcQbK91VDOJPLm9awfWJtpsi=g@mail.gmail.com>
- In-Reply-To
- <20160203035648.GA20732@sigill.intra.peff.net>
On Wed, Feb 3, 2016 at 10:56 AM, Jeff King <peff@peff.net> wrote:
Show 11 quoted lines
> I find it disappointing that we go back to looking for magic sequences
> in the string. Could we perhaps do this more cleanly with a new config
> option? Like a "user.guessIdent" which defaults to true, but people can
> set to false. And without that, we do not do any automagic at all; we
> get the values from the GIT_COMMITTER_* environment or the
> user.{name,email} config variables, or we die().
>
> I think that should allow your use case (and extend the same feature to
> user.name). It wouldn't work on older versions of git, but nor would
> your fix here (the only way to do that is to re-instate "(none)" as
> magical).Should we generalize this use case, i.e. define a list of configuration variables that must be (re-)defined per-repo? Maybe not worth it, I don't know. I can't think of any other variable that should behave this way off the top of my head.
-- Duy