git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

From
Jeff King <peff@peff.net>
Date
Feb 3, 2016, 05:22 UTC
Message-ID
<20160203052209.GA22336@sigill.intra.peff.net>
In-Reply-To
<CACsJy8BHem_8OcnT9KYhKZVhNcQbK91VDOJPLm9awfWJtpsi=g@mail.gmail.com>
On Wed, Feb 03, 2016 at 12:19:20PM +0700, Duy Nguyen wrote:
Show 17 quoted lines
> On Wed, Feb 3, 2016 at 10:56 AM, Jeff King <peff@peff.net> wrote:
> > I find it disappointing that we go back to looking for magic sequences
> > in the string. Could we perhaps do this more cleanly with a new config
> > option? Like a "user.guessIdent" which defaults to true, but people can
> > set to false. And without that, we do not do any automagic at all; we
> > get the values from the GIT_COMMITTER_* environment or the
> > user.{name,email} config variables, or we die().
> >
> > I think that should allow your use case (and extend the same feature to
> > user.name). It wouldn't work on older versions of git, but nor would
> > your fix here (the only way to do that is to re-instate "(none)" as
> > magical).
> 
> Should we generalize this use case, i.e. define a list of
> configuration variables that must be (re-)defined per-repo? Maybe not
> worth it, I don't know. I can't think of any other variable that
> should behave this way off the top of my head.

That's an interesting thought, but I'm not sure how it would work. The ident variables are special in that people are often unhappy with the fallback. What would it mean for somebody to say "do not proceed if diff.renameLimit is not set", and where would we enforce that?

-Peff
Previous: Duy NguyenNext: Duy Nguyen
Message 4 of 16 in “Trick to force setup of a specific configured E-Mail per repo”
  1. Trick to force setup of a specific configured E-Mail per repoDan Aloni, Feb 2, 2016
  2. Jeff KingFeb 3, 2016
  3. Duy NguyenFeb 3, 2016
  4. Jeff KingFeb 3, 2016
  5. Duy NguyenFeb 3, 2016
  6. Jeff KingFeb 3, 2016
  7. Junio C HamanoFeb 3, 2016
  8. Dan AloniFeb 3, 2016
  9. Eric SunshineFeb 3, 2016
  10. Add user.explicit boolean for when ident shouldn't be guessedDan Aloni, Feb 3, 2016
  11. Jeff KingFeb 4, 2016
  12. Jeff KingFeb 4, 2016
  13. Jeff KingFeb 4, 2016
  14. Dan AloniFeb 4, 2016
  15. Jeff KingFeb 4, 2016
  16. Dan AloniFeb 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.