Re: [PATCH 1/2] Modified flag field type in rev_list_info struct in bisect.h. There is no need for flag field to be signed, as it is not supposed to be used as decimal.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 25, 2016, 06:18 UTC
- Message-ID
- <xmqqr3ez5bcf.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAGZ79kaF42yCFWdvqqDSAZbWmUo0UVJGbXCci1LF=ne+cixZ0A@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
> Maybe my exposure to the code was accidentally in a way such that > I ever only saw the version without int.
The older part of the code tends to spell flag words with "unsigned" without "int", which is primarily historical fault of mine.