Re: [PATCH 1/2] Modified flag field type in rev_list_info struct in bisect.h. There is no need for flag field to be signed, as it is not supposed to be used as decimal.

From: work <motroniii@gmail.com>
Date: Mar 24, 2016, 20:01 UTC
Message-ID: <56F44788.2050509@gmail.com>
In-Reply-To: <CAGZ79kZmzo+f9YF1K1oC2GfOrzdaojmrca7bUm3cBRoDreeA-g@mail.gmail.com>

On 03/24/2016 10:51 PM, Stefan Beller wrote:

Show 13 quoted lines

> On Thu, Mar 24, 2016 at 12:41 PM, Motroni Igor <motroniii@gmail.com> wrote:
>> From: Pontifik <motroniii@gmail.com>
> Here is a good place to put reasoning for why this is a good idea.
> I see you have a long subject, so maybe we can shorten the first line
> (down to less than ~ 80 characters) and put the longer explanation
> here.
>
> How about:
>
>    bisect: use unsigned for flag field
>
>    The flags are usually used as a unsigned variable, because it makes
>    bit operations easier to follow.

Yep, it's definitely a good idea to shorten subject in order to put more explanations in body of a message.

Show 6 quoted lines

>
>
>> Signed-off-by: Pontifik <motroniii@gmail.com>
>  From Documentation/SubmittingPatches:
>> Also notice that a real name is used in the Signed-off-by: line. Please
>> don't hide your real name.

Yep, I didn't mean to hide my real name, but coming across lots of new stuff confused me in distinguishing whether I'm asked to enter real name or nickname :)

Show 16 quoted lines

>> ---
>>   bisect.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bisect.h b/bisect.h
>> index acd12ef..a979a7f 100644
>> --- a/bisect.h
>> +++ b/bisect.h
>> @@ -16,7 +16,7 @@ extern struct commit_list *filter_skipped(struct commit_list *list,
>>
>>   struct rev_list_info {
>>          struct rev_info *revs;
>> -       int flags;
>> +       unsigned int flags;
> You can also drop the int here and make it just
> unsigned.

In fact, I just wanted to keep this code clear to understand (as I see this). Unsigned short is also unsigned, but a reader should know that "unsigned" type stands for "unsigned int". Anyway, I'll keep this in mind in future, thanks a lot.

Show 10 quoted lines

>>          int show_timestamp;
>>          int hdr_termination;
>>          const char *header_prefix;
>> --
>> 2.5.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html