Re: [PATCH 1/2] Modified flag field type in rev_list_info struct in bisect.h. There is no need for flag field to be signed, as it is not supposed to be used as decimal.

From: Stefan Beller <sbeller@google.com>
Date: Mar 24, 2016, 19:51 UTC
Message-ID: <CAGZ79kZmzo+f9YF1K1oC2GfOrzdaojmrca7bUm3cBRoDreeA-g@mail.gmail.com>
In-Reply-To: <1458848469-12663-2-git-send-email-motroniii@gmail.com>

On Thu, Mar 24, 2016 at 12:41 PM, Motroni Igor <motroniii@gmail.com> wrote:

> From: Pontifik <motroniii@gmail.com>

Here is a good place to put reasoning for why this is a good idea. I see you have a long subject, so maybe we can shorten the first line (down to less than ~ 80 characters) and put the longer explanation here.

How about:

  bisect: use unsigned for flag field

  The flags are usually used as a unsigned variable, because it makes
  bit operations easier to follow.

>
> Signed-off-by: Pontifik <motroniii@gmail.com>

>From Documentation/SubmittingPatches:
> Also notice that a real name is used in the Signed-off-by: line. Please
> don't hide your real name.

Show 14 quoted lines

> ---
>  bisect.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bisect.h b/bisect.h
> index acd12ef..a979a7f 100644
> --- a/bisect.h
> +++ b/bisect.h
> @@ -16,7 +16,7 @@ extern struct commit_list *filter_skipped(struct commit_list *list,
>
>  struct rev_list_info {
>         struct rev_info *revs;
> -       int flags;
> +       unsigned int flags;

You can also drop the int here and make it just unsigned.

Show 10 quoted lines

>         int show_timestamp;
>         int hdr_termination;
>         const char *header_prefix;
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html