Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2017, 10:03 UTC
Message-ID: <xmqqr2vlbgyk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170830053108.g2xsn43rwulnwn3p@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> Overall I suspect that running our cmd_*() functions multiple times in a
> single process is already going to cause chaos, because they often are
> touching static globals, etc. So it's probably not that big a deal in
> practice to add one more variable to the list, and declare that calling
> cmd_ls_files() anywhere except as the main function of ls-files is
> forbidden.

IIRC there were a few existing violators of this rule around "merge" implementation. It may be a reasonably low hanging fruit to find and fix them.

#leftoverbits

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.