Re: [PATCH] config: use a static lock_file struct
- From
Jeff King <peff@peff.net>
- Date
- Sep 6, 2017, 12:41 UTC
- Message-ID
- <20170906124153.d2kmtes7wmne7xbi@sigill.intra.peff.net>
- In-Reply-To
- <xmqqmv6879zh.fsf@gitster.mtv.corp.google.com>
On Wed, Sep 06, 2017 at 12:59:46PM +0900, Junio C Hamano wrote:
Show 11 quoted lines
> Jeff King <peff@peff.net> writes: > > > In the long run we may want to drop the "tempfiles must remain forever" > > rule. This is certainly not the first time it has caused confusion or > > leaks. And I don't think it's a fundamental issue, just the way the code > > is written. But in the interim, this fix is probably worth doing. > > I notice you also have a series to rework the "must remain forever" > on the list, but nevertheless let's take this one first. > > Will queue.
Yes, this will conflict with that series (but the resolution should just be to throw this one away). I'm fine with taking this in the meantime, though it's certainly not urgent (my main goal was getting the pre-test bits of test-lib.sh to run with leak detection on; I don't think this was actually affecting anybody in the real world).
-Peff