Re: [PATCH 1/2] describe: do not use cmd_*() as a subroutine

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 11, 2017, 06:00 UTC
Message-ID: <xmqqr2uamdfe.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171010134309.13803-1-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

> Maybe you already considered all this WRT that cmd_name_rev() call, I
> don't know.  In any case, I think at least the subject line should
> spell out cmd_diff_index().

Perhaps. The intent was to eradicate cmd_*() used as a subroutine, so I'd rather opt to explain why name_rev() that does not return is OK in this case in the log message without changing anything else.

Thanks for looking it over.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.