Re: Silly "git gc" UI issue.

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2018, 01:52 UTC
Message-ID: <xmqqr2ncezdc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CA+55aFxSZLuk++Dz6SonD+JhbbSDt9G9VcBx5f1CV=6nJC9hvg@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 7 quoted lines

> You get this:
>
>    git gc --prune=npw
>
> Yeah, that "npw" should be "now", which is where the klutz thing comes in.
>
> It turns out that git reacts ridiculously badly to this.

    $ git gc --prune=npw
    Counting objects: 10, done.
    Delta compression using up to 8 threads.
    Compressing objects: 100% (3/3), done.
    Writing objects: 100% (10/10), done.
    Total 10 (delta 2), reused 10 (delta 2)
    error: failed to run prune

It turns out that prune silently goes away given a bad expiry

    $ git prune --expire=nyah ; echo $?
    129

Regardless of your originai "git gc" issue, we should make "prune" say something on this error. And when we do so, I would think that error message will come before the final "error: failed to run prune".

Or perhaps we do so and then squelch "error: failed to run prune", trusting that a corrected "git prune" will always say something when it fails.