Re: Silly "git gc" UI issue.

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Apr 19, 2018, 02:19 UTC
Message-ID: <CA+55aFxSjUmbrocEr=FX=VOJ_-rtbOPYJ9mXFm+J60FKYtw9Vw@mail.gmail.com>
In-Reply-To: <xmqqr2ncezdc.fsf@gitster-ct.c.googlers.com>

On Wed, Apr 18, 2018 at 6:52 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

>
> Regardless of your originai "git gc" issue, we should make "prune"
> say something on this error.  And when we do so, I would think that
> error message will come before the final "error: failed to run
> prune".

So to me, the real failure is the fact that it spent a a lot of time packing my repository before it then failed the prune at the end.

I don't actually mind the quality of the error message too much - although it could be improved.

I mind the "oh, goddamnit, you just spent over a minute of CPU time on my fairly high-end desktop, and _then_ you decided to tell me that I'm a moron and couldn't type 'now' correctly".

So to me, the big deal would be that builtin/gc.c should validate the date *before* it starts, instead of doing all that work, and then executing "git prune" with invalid arguments..

                Linus