git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Silly "git gc" UI issue.

From
Simon Ruderich <simon@ruderich.org>
Date
Apr 20, 2018, 07:27 UTC
Message-ID
<20180420072701.GB13462@ruderich.org>
In-Reply-To
<xmqqh8o7eq7j.fsf@gitster-ct.c.googlers.com>
On Thu, Apr 19, 2018 at 02:10:40PM +0900, Junio C Hamano wrote:
Show 15 quoted lines
> diff --git a/parse-options-cb.c b/parse-options-cb.c
> index c6679cb2cd..872627eafe 100644
> --- a/parse-options-cb.c
> +++ b/parse-options-cb.c
> @@ -38,7 +38,11 @@ int parse_opt_approxidate_cb(const struct option *opt, const char *arg,
>  int parse_opt_expiry_date_cb(const struct option *opt, const char *arg,
>  			     int unset)
>  {
> -	return parse_expiry_date(arg, (timestamp_t *)opt->value);
> +	if (unset)
> +		arg = "never";
> +	if (parse_expiry_date(arg, (timestamp_t *)opt->value))
> +		die("malformed expiration date '%s'", arg);
> +	return 0;
>  }
Should this error get translated?

Regards Simon

-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 14 in “Silly "git gc" UI issue.”
  1. Linus TorvaldsApr 19, 2018
  2. Junio C HamanoApr 19, 2018
  3. Junio C HamanoApr 19, 2018
  4. Junio C HamanoApr 19, 2018
  5. Linus TorvaldsApr 19, 2018
  6. Junio C HamanoApr 19, 2018
  7. Junio C HamanoApr 19, 2018
  8. Simon RuderichApr 20, 2018
  9. Junio C HamanoApr 21, 2018
  10. Christian CouderApr 21, 2018
  11. Junio C HamanoApr 23, 2018
  12. Linus TorvaldsApr 19, 2018
  13. Simon RuderichApr 19, 2018
  14. Junio C HamanoApr 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.