Re: Silly "git gc" UI issue.

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 21, 2018, 06:07 UTC
Message-ID: <CAP8UFD0_LvWkKSYd1MWrdoK-tqBcQqm32CUNrBqEfmjWdHkJgg@mail.gmail.com>
In-Reply-To: <xmqqlgdhb6ba.fsf@gitster-ct.c.googlers.com>

On Sat, Apr 21, 2018 at 5:13 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> @@ -388,6 +389,9 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
>         if (argc > 0)
>                 usage_with_options(builtin_gc_usage, builtin_gc_options);
>
> +       if (prune_expire && parse_expiry_date(prune_expire, &dummy))
> +               die(_("Failed to parse prune expiry value %s"), prune_expire);

Micronit: I thought we prefer error messages to start with a lower
case letter, like:

               die(_("failed to parse prune expiry value %s"), prune_expire);