Re: [PATCH 2/3] color.c: Support bright aixterm colors

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 21, 2020, 17:37 UTC
Message-ID: <xmqqr1zsbtip.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CANsz78+-Z89d8E=n3cjfnXaGVFXpchdG7EjtdQuFjzo-=2aPeA@mail.gmail.com>

Eyal Soha <shawarmakarma@gmail.com> writes:

Show 13 quoted lines

>> I have to wonder if spelling "bright<color>", i.e. two words smashed
>> together without anything in between words, is in widespread use (in
>> other words, are we following an established practice, or are we
>> inventing our own), or if we need to prepare for synonyms?  HTML/CSS
>> folks seem to use words-smashed-without-anything-in-betwen so they
>> should be fine with this design; I no longer recall what X did ;-)
>
> /usr/local/lib/X11/rgb.txt often uses smashed together:
> https://github.com/vim/vim/blob/master/runtime/rgb.txt  Wikipedia
> calls them "bright" consistently:
> https://en.wikipedia.org/wiki/ANSI_escape_code#Colors .  So we've got
> a vote for smashing them together and a vote for "bright".  Seems okay
> by me!

OK. By synonym, I did not mean any word other than "bright"; in the context of my response, "brightred", "bright red" and "bright-red" would have been synonyms, but I think it is sufficient to support only the first one.

Of course, somebody may come up with a bright idea to treat the "bright" adjective just like "underline" and "bold" and that might improve the end user experience slightly better, but I dunno ;-)