git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/3] color.c: refactor color_output arguments

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 11, 2020, 23:06 UTC
Message-ID
<xmqqo8u4vi3w.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CANsz78Jv6VZPx+XeFTnRTFofrVj-jrmx2-rFtXJpbfM3XMTS+w@mail.gmail.com>
Eyal Soha <shawarmakarma@gmail.com> writes:
> Had I gotten any of those constants wrong, unit tests would fail.

To be fair, the tests only look for hardcoded numeric constants like 91 and 104, so it won't be able to catch a mistake like "oh, we thought bright red was 91 but actually it was 111" ;-)

> None of those values are likely to ever change.  I think that the most
> important feature of the constants is that they are descriptive.
Yup.  Thanks for bringing up and working on the topic.
Previous: Eyal SohaNext: Junio C Hamano
Message 31 of 37 in “Fwd: Add support for axiterm colors in parse_color”
  1. Eyal SohaJan 7, 2020
  2. Jeff KingJan 8, 2020
  3. Eyal SohaJan 10, 2020
  4. Jeff KingJan 10, 2020
  5. Eyal SohaJan 10, 2020
  6. Eyal SohaJan 15, 2020
  7. 1/3 color.c: Refactor color_output to use enumsEyal Soha, Jan 10, 2020
  8. 2/3 color.c: Support bright aixterm colorsEyal Soha, Jan 10, 2020
  9. Jeff KingJan 15, 2020
  10. 3/3 color.c: Alias RGB colors 8-15 to aixterm colorsEyal Soha, Jan 10, 2020
  11. Jeff KingJan 15, 2020
  12. Jeff KingJan 15, 2020
  13. Junio C HamanoJan 16, 2020
  14. Jeff KingJan 16, 2020
  15. Eyal SohaJan 16, 2020
  16. 1/3 color.c: Refactor color_output to use enumsEyal Soha, Jan 18, 2020
  17. 2/3 color.c: Support bright aixterm colorsEyal Soha, Jan 18, 2020
  18. Junio C HamanoJan 18, 2020
  19. Eyal SohaJan 21, 2020
  20. 1/3 color.c: refactor color_output argumentsEyal Soha, Jan 21, 2020
  21. 2/3 color.c: support bright aixterm colorsEyal Soha, Jan 21, 2020
  22. Junio C HamanoJan 23, 2020
  23. 3/3 color.c: alias RGB colors 8-15 to aixterm colorsEyal Soha, Jan 21, 2020
  24. Junio C HamanoJan 23, 2020
  25. 0/3 es/bright-colors (hopefully final) rerollJunio C Hamano, Feb 11, 2020
  26. 2/3 color.c: support bright aixterm colorsJunio C Hamano, Feb 11, 2020
  27. 3/3 color.c: alias RGB colors 8-15 to aixterm colorsJunio C Hamano, Feb 11, 2020
  28. 1/3 color.c: refactor color_output argumentsJunio C Hamano, Feb 11, 2020
  29. Jeff KingFeb 11, 2020
  30. Eyal SohaFeb 11, 2020
  31. Junio C HamanoFeb 11, 2020
  32. Junio C HamanoJan 21, 2020
  33. 3/3 color.c: Alias RGB colors 8-15 to aixterm colorsEyal Soha, Jan 18, 2020
  34. Junio C HamanoJan 18, 2020
  35. Junio C HamanoJan 18, 2020
  36. Eyal SohaJan 21, 2020
  37. Junio C HamanoJan 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.