git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] color.c: Alias RGB colors 8-15 to aixterm colors

From
Eyal Soha <shawarmakarma@gmail.com>
Date
Jan 18, 2020, 14:53 UTC
Message-ID
<20200118145318.5177-3-shawarmakarma@gmail.com>
In-Reply-To
<20200118145318.5177-1-shawarmakarma@gmail.com>

This results in shorter output, and is _probably_ more portable. There is at least one environment (GitHub Actions) which supports 16-color mode but not 256-color mode. It's possible there are environments which go the other way, but it seems unlikely.

Signed-off-by: Eyal Soha <shawarmakarma@gmail.com>
---
 color.c          | 7 ++++++-
 t/t4026-color.sh | 4 ++++
 2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/color.c b/color.c
index 66d32e1191..ba067ed97a 100644
--- a/color.c
+++ b/color.c
@@ -136,11 +136,16 @@ static int parse_color(struct color *out, const char *name, int len)
 		else if (val < 0) {
 			out->type = COLOR_NORMAL;
 			return 0;
-		/* Rewrite low numbers as more-portable standard colors. */
+		/* Rewrite 0-7 as more-portable standard colors. */
 		} else if (val < 8) {
 			out->type = COLOR_ANSI;
 			out->value = val + COLOR_FOREGROUND_ANSI;
 			return 0;
+		/* Rewrite 8-15 as more-portable aixterm colors. */
+		} else if (val < 16) {
+			out->type = COLOR_ANSI;
+			out->value = val - 8 + COLOR_FOREGROUND_BRIGHT_ANSI;
+			return 0;
 		} else if (val < 256) {
 			out->type = COLOR_256;
 			out->value = val;
diff --git a/t/t4026-color.sh b/t/t4026-color.sh
index 78c69de90a..c0b642c1ab 100755
--- a/t/t4026-color.sh
+++ b/t/t4026-color.sh
@@ -82,6 +82,10 @@ test_expect_success '0-7 are aliases for basic ANSI color names' '
 	color "0 7" "[30;47m"
 '
 
+test_expect_success '8-15 are aliases for aixterm color names' '
+	color "12 13" "[94;105m"
+'
+
 test_expect_success '256 colors' '
 	color "254 bold 255" "[1;38;5;254;48;5;255m"
 '
-- 
2.25.0.rc2.3.g8712c6e7f0
Previous: Junio C HamanoNext: Junio C Hamano
Message 33 of 37 in “Fwd: Add support for axiterm colors in parse_color”
  1. Eyal SohaJan 7, 2020
  2. Jeff KingJan 8, 2020
  3. Eyal SohaJan 10, 2020
  4. Jeff KingJan 10, 2020
  5. Eyal SohaJan 10, 2020
  6. Eyal SohaJan 15, 2020
  7. 1/3 color.c: Refactor color_output to use enumsEyal Soha, Jan 10, 2020
  8. 2/3 color.c: Support bright aixterm colorsEyal Soha, Jan 10, 2020
  9. Jeff KingJan 15, 2020
  10. 3/3 color.c: Alias RGB colors 8-15 to aixterm colorsEyal Soha, Jan 10, 2020
  11. Jeff KingJan 15, 2020
  12. Jeff KingJan 15, 2020
  13. Junio C HamanoJan 16, 2020
  14. Jeff KingJan 16, 2020
  15. Eyal SohaJan 16, 2020
  16. 1/3 color.c: Refactor color_output to use enumsEyal Soha, Jan 18, 2020
  17. 2/3 color.c: Support bright aixterm colorsEyal Soha, Jan 18, 2020
  18. Junio C HamanoJan 18, 2020
  19. Eyal SohaJan 21, 2020
  20. 1/3 color.c: refactor color_output argumentsEyal Soha, Jan 21, 2020
  21. 2/3 color.c: support bright aixterm colorsEyal Soha, Jan 21, 2020
  22. Junio C HamanoJan 23, 2020
  23. 3/3 color.c: alias RGB colors 8-15 to aixterm colorsEyal Soha, Jan 21, 2020
  24. Junio C HamanoJan 23, 2020
  25. 0/3 es/bright-colors (hopefully final) rerollJunio C Hamano, Feb 11, 2020
  26. 2/3 color.c: support bright aixterm colorsJunio C Hamano, Feb 11, 2020
  27. 3/3 color.c: alias RGB colors 8-15 to aixterm colorsJunio C Hamano, Feb 11, 2020
  28. 1/3 color.c: refactor color_output argumentsJunio C Hamano, Feb 11, 2020
  29. Jeff KingFeb 11, 2020
  30. Eyal SohaFeb 11, 2020
  31. Junio C HamanoFeb 11, 2020
  32. Junio C HamanoJan 21, 2020
  33. 3/3 color.c: Alias RGB colors 8-15 to aixterm colorsEyal Soha, Jan 18, 2020
  34. Junio C HamanoJan 18, 2020
  35. Junio C HamanoJan 18, 2020
  36. Eyal SohaJan 21, 2020
  37. Junio C HamanoJan 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.