Re: [PATCH] pager: exit without error on SIGPIPE

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2021, 18:12 UTC
Message-ID: <xmqqr1lxc96e.fsf@gitster.c.googlers.com>
In-Reply-To: <aa672f2b-6886-a2bf-5129-f10f4e488961@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 8 quoted lines

>> I guess we are then in agreement---I do think it makes sense to send
>> the true exit code from the pager as the exit code from the pager to
>> the trace output, which is what the early part of Ævar's patch does,
>> but I do not think the exit code of the pager should affect the exit
>> code from "git log" as a whole.
>
> Then we do not agree. The exit code of `git log | less` is ignored, and
> I regard `git -p log` just as a short-hand for that.

I think you skipped "not" while reading the "but I do not think" part of the last sentence.

> The only thing I care is that git does not die due to a SIGPIPE when the
> pager is closed early.

Makes two of us ;-)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.