git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git fails with a broken pipe when one quits the pager

From
Johannes Sixt <j6t@kdbg.org>
Date
Feb 3, 2021, 17:11 UTC
Message-ID
<1222a249-818a-5ca7-2187-9a3b9ab5eb5b@kdbg.org>
In-Reply-To
<87o8h1euix.fsf@evledraar.gmail.com>
Am 03.02.21 um 03:48 schrieb Ævar Arnfjörð Bjarmason:
Show 27 quoted lines
> 
> On Mon, Feb 01 2021, Johannes Sixt wrote:
> 
>> Am 01.02.21 um 16:44 schrieb Ævar Arnfjörð Bjarmason:
>>> On Mon, Feb 01 2021, Vincent Lefevre wrote:
>>>> On 2021-02-01 13:10:21 +0100, Ævar Arnfjörð Bjarmason:
>>>>> So we've got the SIGPIPE to indicate the output wasn't fully
>>>>> consumed.
>>>>
>>>> But the user doesn't care: he quit the pager because he didn't
>>>> need more output. So there is no need to signal that the output
>>>> wasn't fully consumed. The user already knew that before quitting
>>>> the pager!
>>>
>>> As noted above, this is assuming way too much about the functionality of
>>> the pager command. We can get a SIGPIPE without the user's intent in
>>> this way. Consider e.g. piping to some remote system via netcat.
>>
>> That assumption is warranted, IMO. Aren't _you_ stretching the meaning
>> of "pager" too far here? A pager is intended for presentation to the
>> user. If someone plays games with it, they should know what they get.
> 
> FWIW I replied to this in
> https://lore.kernel.org/git/87r1lxeuoj.fsf@evledraar.gmail.com/
> 
> Whatever anyone thinks of the virtues of passing down SIGHUP having e.g
> a nc to a remote box be your pager isn't all that unusual.

A pager in any form is fair game. That point is that it is an *interactive* form of presentation. But you should not use git's pager as data post-processing facility; that would stretch the meaning of "pager" too far, and we do not have cater for such abuse of the feature.

-- Hannes
Previous: Ævar Arnfjörð BjarmasonNext: Vincent Lefevre
Message 56 of 60 in “git fails with a broken pipe when one quits the pager”
  1. Vincent LefevreJan 15, 2021
  2. pager: exit without error on SIGPIPEDenton Liu, Jan 29, 2021
  3. Johannes SixtJan 30, 2021
  4. Johannes SixtJan 30, 2021
  5. Ævar Arnfjörð BjarmasonFeb 1, 2021
  6. Junio C HamanoFeb 1, 2021
  7. Ævar Arnfjörð BjarmasonFeb 1, 2021
  8. Junio C HamanoFeb 1, 2021
  9. Ævar Arnfjörð BjarmasonFeb 2, 2021
  10. Junio C HamanoFeb 2, 2021
  11. Junio C HamanoFeb 2, 2021
  12. Johannes SixtFeb 2, 2021
  13. Junio C HamanoFeb 2, 2021
  14. Johannes SixtFeb 2, 2021
  15. Junio C HamanoFeb 2, 2021
  16. Johannes SixtFeb 3, 2021
  17. Junio C HamanoFeb 3, 2021
  18. Vincent LefevreFeb 4, 2021
  19. Ævar Arnfjörð BjarmasonFeb 3, 2021
  20. Junio C HamanoFeb 3, 2021
  21. Ævar Arnfjörð BjarmasonFeb 3, 2021
  22. Johannes SixtFeb 3, 2021
  23. Ævar Arnfjörð BjarmasonJan 31, 2021
  24. Vincent LefevreJan 31, 2021
  25. Vincent LefevreJan 31, 2021
  26. Ævar Arnfjörð BjarmasonJan 31, 2021
  27. Vincent LefevreFeb 1, 2021
  28. Chris TorekFeb 1, 2021
  29. Vincent LefevreFeb 1, 2021
  30. Chris TorekFeb 1, 2021
  31. Vincent LefevreFeb 1, 2021
  32. Ævar Arnfjörð BjarmasonFeb 1, 2021
  33. Ævar Arnfjörð BjarmasonFeb 1, 2021
  34. 3/3 pager: properly log pager exit code when signalledÆvar Arnfjörð Bjarmason, Feb 1, 2021
  35. Junio C HamanoFeb 1, 2021
  36. Ævar Arnfjörð BjarmasonFeb 1, 2021
  37. Junio C HamanoFeb 1, 2021
  38. Ævar Arnfjörð BjarmasonFeb 1, 2021
  39. 2/3 pager: refactor wait_for_pager() functionÆvar Arnfjörð Bjarmason, Feb 1, 2021
  40. 1/3 pager: test for exit codeÆvar Arnfjörð Bjarmason, Feb 1, 2021
  41. 0/3 pager: test for exit behavior & trace2 bug fixÆvar Arnfjörð Bjarmason, Feb 1, 2021
  42. 1/5 pager: refactor wait_for_pager() functionÆvar Arnfjörð Bjarmason, Feb 2, 2021
  43. 0/5 pager: test for exit behavior & trace2 bug fixÆvar Arnfjörð Bjarmason, Feb 2, 2021
  44. 3/5 run-command: add braces for "if" block in wait_or_whine()Ævar Arnfjörð Bjarmason, Feb 2, 2021
  45. 2/5 pager: test for exit code with and without SIGPIPEÆvar Arnfjörð Bjarmason, Feb 2, 2021
  46. Denton LiuFeb 2, 2021
  47. Johannes SixtFeb 5, 2021
  48. 4/5 pager: properly log pager exit code when signalledÆvar Arnfjörð Bjarmason, Feb 2, 2021
  49. Johannes SixtFeb 5, 2021
  50. Junio C HamanoFeb 5, 2021
  51. 5/5 WIP pager: respect exit code of pager over SIGPIPEÆvar Arnfjörð Bjarmason, Feb 2, 2021
  52. Vincent LefevreFeb 1, 2021
  53. Ævar Arnfjörð BjarmasonFeb 1, 2021
  54. Johannes SixtFeb 1, 2021
  55. Ævar Arnfjörð BjarmasonFeb 3, 2021
  56. Johannes SixtFeb 3, 2021
  57. Vincent LefevreFeb 3, 2021
  58. Ævar Arnfjörð BjarmasonFeb 4, 2021
  59. Vincent LefevreFeb 4, 2021
  60. Johannes SixtFeb 1, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.