Re: Fix for failing tests on Solaris
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2022, 16:48 UTC
- Message-ID
- <xmqqr15fdedp.fsf@gitster.g>
- In-Reply-To
- <20220429160913.wogvmyxosctdlosz@carlos-mbp.lan>
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
Show 21 quoted lines
>> --- git-2.35.1/config.mak.uname >> +++ git-2.35.1/config.mak.uname >> @@ -162,7 +162,7 @@ ifeq ($(uname_S),SunOS) >> NEEDS_SOCKET = YesPlease >> NEEDS_NSL = YesPlease >> SHELL_PATH = /bin/bash >> - SANE_TOOL_PATH = /usr/xpg6/bin:/usr/xpg4/bin >> + SANE_TOOL_PATH = /usr/gnu/bin > > I haven't used Solaris for a while (since around OpenSolaris Indiana > development stopped), but wouldn't this break in Solaris 10 and older? > >> Makes all tests but t7812 pass successfully. t7812 fails on locales and >> utf-8 which do behave differently in Solaris. > > And additional fix for that (since you seem to have access to a fresh > Solaris 11.4 installation at least), would be forthcomming. > > Wondering also if there is a way to plug one of those from Oracle Cloud > through a GitHub actions so we could prevent future issues by including > Solaris in our CI runs.
I do not think we want to take this patch until we know how exactly the tests failing for Vladimir fail without GNUism, which we do not want to rely on. If a test by mistake used "sed -i -e '<script>'" GNUism which /usr/xpg[46]/bin/sed does not support, for example, we want to know about it, so that we can move away from such a use of GNUism.
Thanks.